Messages in this thread | | | Date | Tue, 22 Nov 2005 14:13:53 -0800 | From | Greg KH <> | Subject | Re: [PATCH 2/2] - usbserial: race-condition fix. |
| |
On Tue, Nov 22, 2005 at 07:59:26PM -0200, Luiz Fernando Capitulino wrote: > @@ -60,6 +61,7 @@ struct usb_serial_port { > struct usb_serial * serial; > struct tty_struct * tty; > spinlock_t lock; > + struct semaphore sem;
You forgot to document what this semaphore is used for.
Hm, can we just use the spinlock already present in the port structure for this? Well, drop the spinlock and use the semaphore? Yeah, that means grabbing a semaphore for ever write for some devices, but USB data rates are slow enough it wouldn't matter :)
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |