Messages in this thread | | | Date | Sun, 20 Nov 2005 22:59:59 -0800 | From | Miles Lane <> | Subject | Re: 2.6.15-rc1-mm2 -- Bad page state at free_hot_cold_page (in process 'aplay', page c18eef30) |
| |
On 11/20/05, Hugh Dickins <hugh@veritas.com> wrote: > On Sun, 20 Nov 2005, Lee Revell wrote: > > (Added alsa-devel to cc:) > > > > Will this change have any ill effects on older kernels? > > I think not (except 2.6.5 and earlier didn't define __GFP_COMP). > > > If not we should fix it in the ALSA tree right? > > Probably, but I'm no authority on the ALSA tree. > > And suggest you wait a bit, since I haven't yet signed off on the > patch that piece will be a part of. > > And what about the patch at the bottom (which I had CC'ed to Karsten > Wiese), is that part of the ALSA tree too? That case isn't so easy: > the get_page makes a difference, and probably it was right not to do > it before, yet strange it was the only nopage in the tree which didn't > get_page. > > Hugh > > > Lee > > > > On Sun, 2005-11-20 at 08:05 +0000, Hugh Dickins wrote: > > > On Sat, 19 Nov 2005, Miles Lane wrote: > > > > [17179671.700000] Bad page state at free_hot_cold_page (in process > > > > 'aplay', page c18eef30) > > > > [17179671.700000] flags:0x80000414 mapping:00000000 mapcount:0 count:0 > > > > > > Please let me know if it's not fixed by: > > > > > > --- 2.6.15-rc1-mm2/sound/core/memalloc.c 2005-11-12 09:01:28.000000000 +0000 > > > +++ linux/sound/core/memalloc.c 2005-11-19 19:03:32.000000000 +0000 > > > @@ -197,6 +197,7 @@ void *snd_malloc_pages(size_t size, gfp_ > > > > > > snd_assert(size > 0, return NULL); > > > snd_assert(gfp_flags != 0, return NULL); > > > + gfp_flags |= __GFP_COMP; /* compound page lets parts be mapped */ > > > pg = get_order(size); > > > if ((res = (void *) __get_free_pages(gfp_flags, pg)) != NULL) { > > > mark_pages(virt_to_page(res), pg); > > > @@ -241,6 +242,7 @@ static void *snd_malloc_dev_pages(struct > > > snd_assert(dma != NULL, return NULL); > > > pg = get_order(size); > > > gfp_flags = GFP_KERNEL > > > + | __GFP_COMP /* compound page lets parts be mapped */ > > > | __GFP_NORETRY /* don't trigger OOM-killer */ > > > | __GFP_NOWARN; /* no stack trace print - this call is non-critical */ > > > res = dma_alloc_coherent(dev, PAGE_SIZE << pg, dma, gfp_flags);
Thanks, this did fix the problem for me.
Miles - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |