Messages in this thread | | | Date | Mon, 21 Nov 2005 10:56:09 -0800 | From | Ben Collins <> | Subject | Re: [2.6 patch] drivers/ieee1394/raw1394.c: fix a NULL pointer dereference |
| |
> >- CSR1212_FREE(cache); > > ret = -EFAULT; > > } else { > > cache->len = req->req.length; > > This looks OK to me. But there seems to be another bug. I think the line > > kfree(cache); > > after the if and else blocks has to be replaced by > > CSR1212_FREE(cache);
Yes, please. We are trying to keep the csr1212.[ch] files compatible for use in userspace and kernel.
-- Ubuntu - http://www.ubuntu.com/ Debian - http://www.debian.org/ Linux 1394 - http://www.linux1394.org/ SwissDisk - http://www.swissdisk.com/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |