Messages in this thread Patch in this message | | | Date | Wed, 2 Nov 2005 10:10:59 +0100 | From | Adrian Bunk <> | Subject | [2.6 patch] drivers/block/pktcdvd.c: remove write-only variable in pkt_iosched_process_queue() |
| |
Found this on Coverty's linux bug database (http://linuxbugsdb.coverity.com).
The function pkt_iosched_process_queue makes a call to bdev_get_queue and stores the result but never uses it, so it looks like it can be safely removed.
From: Gabriel A. Devenyi <ace@staticwave.ca>
Signed-off-by: Gabriel A. Devenyi <ace@staticwave.ca> Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- a/drivers/block/pktcdvd.c +++ b/drivers/block/pktcdvd.c @@ -501,14 +501,11 @@ static void pkt_queue_bio(struct pktcdvd */ static void pkt_iosched_process_queue(struct pktcdvd_device *pd) { - request_queue_t *q; if (atomic_read(&pd->iosched.attention) == 0) return; atomic_set(&pd->iosched.attention, 0); - q = bdev_get_queue(pd->bdev); - for (;;) { struct bio *bio; int reads_queued, writes_queued; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |