Messages in this thread | | | Date | Wed, 2 Nov 2005 22:08:43 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 2/3] swsusp: move snapshot-handling functions to snapshot.c |
| |
Hi!
> > > That depends on how you implement the interface. If you insist on using > > > ioctls then yes, it's ugly. However, if it is a file in sysfs, for example, > > > then you have well-defined open(), close(), read() and write() operations > > > and it is assumed you will keep some context accross eg. write()s. > > > > I was trying to keep kernel code simple. Yes, if we do it sysfs based, > > that's probably not a problem. I'm not sure if nice sysfs interface > > can be done without excessive ammount of code. > > I'm not sure either, but I'm going to try.
Ok, I'm looking forward. We still have my ugly ioctls as a fallback :-).
> Still first I'd like to make swsusp free only as much memory as needed > and not as much as possible which should improve its performance > quite a bit.
Yes, I'd like that patch in. It will make many people happy. Pavel -- Thanks, Sharp! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |