lkml.org 
[lkml]   [2005]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [DEBUG INFO]IPv6: sleeping function called from invalid context.
    From
    On Sat, Nov 19, 2005 at 10:04:11PM +0100, Thomas Graf wrote:
    >
    > The continued dumps wouldn't be the problem, the walker is allocated
    > on the initial dump call. It was a mistake though, nlk->cb_lock spin
    > lock is always held for cb->dump() even though it should only be
    > required during the nlk->cb != NULL check. netlink_dump_start()
    > guarantees to only allow one dumper per socket at a time.

    You're certainly right that the initial dump is what's causing the
    problem.

    I think the spin lock is still required though because we also need
    to guard against netlink_release which can occur at any time since
    the packet processing could be occuring in a different thread from
    the one that did the sendmsg.

    Cheers,
    --
    Visit Openswan at http://www.openswan.org/
    Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-11-19 23:41    [W:0.022 / U:60.080 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site