Messages in this thread | | | Date | Fri, 18 Nov 2005 19:24:30 -0800 | From | William Lee Irwin III <> | Subject | Re: [PATCH] Fix race in set_max_huge_pages for multiple updaters of nr_huge_pages |
| |
On Fri, Nov 18, 2005 at 07:09:50PM -0800, Andrew Morton wrote: > Nope, alloc_fresh_huge_page() does a GFP_HIGHUSER allocation, which can > sleep and may not be called inside spinlock. You would have seen a spew of > might_sleep() warnings if this was tested with the appropriate kernel > debugging options. > How about this?
Looks good. My reply got stuck behind a queue of other things to do since it needed a correction.
Acked-by: William Irwin <wli@holomorphy.com>
-- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |