lkml.org 
[lkml]   [2005]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: mmap over nfs leads to excessive system load
From
Date
On Wed, 2005-11-16 at 16:25 -0800, Andrew Morton wrote:
> Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
> >
> > The accompanying NFS patch makes use of this in order to figure out when
> > to flush the data correctly.
>
> OK. So with that patch, nfs_writepages() may still leave I/O pending,
> uninitiated, yes?
>
> I don't understand why NFS hasn't been BUGging as it stands at present. It
> has several end_page_writeback() calls but no set_page_writeback()s.
> end_page_writeback() or rotate_reclaimable_page() will go BUG if the page
> wasn't PageWriteback().

It does have SetPageWriteback() calls in the asynchronous writeback
path. As you can see from the patch I just sent, I only needed to
replace them with set_page_writebacks().

Cheers,
Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-17 01:30    [W:0.113 / U:5.824 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site