lkml.org 
[lkml]   [2005]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [RFC] [PATCH 00/13] Introduce task_pid api
From
Date
On Sun, 2005-11-13 at 15:22 +0000, Pavel Machek wrote:
> > @@ -2925,7 +2925,7 @@ void submit_bio(int rw, struct bio *bio)
> > if (unlikely(block_dump)) {
> > char b[BDEVNAME_SIZE];
> > printk(KERN_DEBUG "%s(%d): %s block %Lu on %s\n",
> > - current->comm, current->pid,
> > + current->comm, task_pid(current),
> > (rw & WRITE) ? "WRITE" : "READ",
> > (unsigned long long)bio->bi_sector,
> > bdevname(bio->bi_bdev,b));
>
> ...and now printk is close to useless, because uer can't know to which
> pidspace that pid belongs. Oops.

That is true, but only if we print the virtualized pid. Before we go
and actually implement the pid virtualization, we probably need a
thorough audit of this kind of stuff to see what we really want.

There will always be a "real pid" (the real thing in tsk->__pid) backing
whatever is virtualized and presented to getpid(). I would imagine that
this is the same that needs to go into dmesg.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-11-16 21:27    [W:0.163 / U:0.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site