Messages in this thread | | | Date | Wed, 16 Nov 2005 07:56:01 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH] libata error handling fixes (ATAPI) |
| |
Jens Axboe wrote: > I updated that patch, and converted IDE and SCSI to use it. See the > results here: > > http://brick.kernel.dk/git/?p=linux-2.6-block.git;a=shortlog;h=blk-softirq > > The main change from the version posted last october is killing the > 'slightly' overdesigned completion queue hashing.
Nifty, I like. Comments:
* use of spin_lock_irq() in all completion paths now makes me nervous.
* certainly it's what SCSI does now, but is a softirq really necessary? Using a tasklet would kill all that per-cpu code, and notifier.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |