Messages in this thread | | | Date | Tue, 15 Nov 2005 02:16:02 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH ] Fix some problems with truncate and mtime semantics. |
| |
Christoph Hellwig <hch@infradead.org> wrote: > > > -int do_truncate(struct dentry *dentry, loff_t length, struct file *filp) > > +int do_truncate(struct dentry *dentry, loff_t length, unsigned int time_attrs, > > + struct file *filp) > > { > > int err; > > struct iattr newattrs; > > @@ -204,7 +205,7 @@ int do_truncate(struct dentry *dentry, l > > return -EINVAL; > > > > newattrs.ia_size = length; > > - newattrs.ia_valid = ATTR_SIZE | ATTR_CTIME; > > + newattrs.ia_valid = ATTR_SIZE | time_attrs; > > I'd rather make the argument and boolean update_times flag and this: >
That sentence is incomprehensible. Want to have another go?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |