Messages in this thread | | | Date | Tue, 15 Nov 2005 15:04:51 -0800 (PST) | From | "Randy.Dunlap" <> | Subject | Re: [PATCH 1/5] Light Fragmentation Avoidance V20: 001_antidefrag_flags |
| |
On Tue, 15 Nov 2005, Paul Jackson wrote:
> Mel wrote: > > #define __GFP_VALID ((__force gfp_t)0x80000000u) /* valid GFP flags */ > > > > +/* > > + * Allocation type modifier > > + * __GFP_EASYRCLM: Easily reclaimed pages like userspace or buffer pages > > + */ > > +#define __GFP_EASYRCLM 0x80000u /* User and other easily reclaimed pages */ > > + > > How about fitting the style (casts, just one line) of the other flags, > so that these added six lines become instead just the one line: > > #define __GFP_EASYRCLM ((__force gfp_t)0x80000u) /* easily reclaimed pages */ > > (Yeah - it was probably me that asked for -more- comments sometime in > the past - consistency is not my strong suit ;).
Conversely, if you are going to go to the effort of lots of docs, please do it in kernel-doc format. Documentation/kernel-doc-nano-HOWTO.txt
-- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |