Messages in this thread | | | Date | Mon, 14 Nov 2005 14:35:59 -0800 | From | Greg KH <> | Subject | Re: [PATCH 1/7] PCI Error Recovery: header file patch |
| |
On Tue, Nov 08, 2005 at 04:11:58PM -0800, Stephen Hemminger wrote: > > > > > +/** The pci_channel state describes connectivity between the CPU and > > + * the pci device. If some PCI bus between here and the pci device > > + * has crashed or locked up, this info is reflected here. > > + */ > > +typedef int __bitwise pci_channel_state_t; > > Bit operations should be on unsigned not signed value.
Agreed. I'll wait for Linas to respin these.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |