Messages in this thread Patch in this message | | | From | "Gabriel A. Devenyi" <> | Subject | [RESEND] [PATCH] drivers/acpi/asus_acpi.c unsigned comparison | Date | Sat, 12 Nov 2005 16:16:14 -0500 |
| |
It helps if I attach the patch.
proc_write_brn, and proc_write_disp both use a parameter "count" to store the result from parse_arg. The return of parse_arg is an int, but count is declared as an unsigned int, and later checked versus zero, which is meaningless. This patch fixes the declaration of count in both functions.
Thanks to LinuxICC (http://linuxicc.sf.net)
Signed-off-by: Gabriel A. Devenyi <ace@staticwave.ca>
diff --git a/drivers/acpi/asus_acpi.c b/drivers/acpi/asus_acpi.c index fec895a..9dfd0cd 100644 --- a/drivers/acpi/asus_acpi.c +++ b/drivers/acpi/asus_acpi.c @@ -748,7 +748,7 @@ proc_read_brn(char *page, char **start, static int proc_write_brn(struct file *file, const char __user * buffer, - unsigned long count, void *data) + long count, void *data) { int value; @@ -798,7 +798,7 @@ proc_read_disp(char *page, char **start, */ static int proc_write_disp(struct file *file, const char __user * buffer, - unsigned long count, void *data) + long count, void *data) { int value;
-- Gabriel A. Devenyi ace@staticwave.ca - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |