Messages in this thread | | | Date | Fri, 11 Nov 2005 06:36:28 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH 1/1] cciss: scsi error handling |
| |
mike.miller@hp.com wrote: > PATCH 1 of 1 > > This patch adds SCSI error handling code to the SCSI portion > of the cciss driver. > > Signed-off-by: Stephen M. Cameron <steve.cameron@hp.com> > Acked-by: Mike Miller <mike.miller@hp.com>
> +#ifdef CONFIG_CISS_SCSI_TAPE
Two comments:
1) CONFIG_CISS_SCSI_TAPE should be CONFIG_CCISS_SCSI_TAPE, IMO
2) is any locking needed in your scsi eh reset handlers? recent kernels eliminate the lock that's been traditionally held around the handlers.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |