Messages in this thread | | | Date | Sat, 12 Nov 2005 07:55:46 +0800 | From | "Antonino A. Daplas" <> | Subject | Re: [PATCH] nvidiafb: Fix bug in nvidiafb_pan_display |
| |
Benjamin Herrenschmidt wrote: > On Sat, 2005-11-12 at 07:28 +0800, Antonino A. Daplas wrote: >> nvidiafb_pan_display() is incorrectly using the fields in >> info->var instead of var passed to the function. > > Shouldn't it also update info->var is is this done by the core ? >
Nobody calls or should call fbops->fb_pan_display() directly except the wrapper fb_pan_display() in fbmem.c. It already does the checking and the update to info->var. So checking and updating for the offsets will be redundant.
Tony - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |