Messages in this thread | | | Date | Fri, 11 Nov 2005 20:18:40 +0100 | From | Pavel Machek <> | Subject | Re: sharpsl_pm: using milivolts instead of custom units? |
| |
Hi!
> > #ifdef CONFIG_SA1100_COLLIE > > struct battery_thresh spitz_battery_levels_noac[] = { > > { 368, 100}, > > { 358, 25}, > > { 356, 5}, > > { 0, 0}, > > ... > > > > ...so it could get very confusing. Would it be feasible to convert to > > mV as soon as possible and have all constants in milivolts? I realize > > they may be slightly different for different models, but they should > > at least be comparable. > > The battery levels are totally different between the models and each is > going to need a levels translation table as its an extremely none linear > decay curve. Using ADC values here makes a lot of sense as that's as > granular as the information ever gets and you don't start to lose > accuracy anywhere with rounding.
Well, all the models have li-ion batteries, so levels (in milivolts) for stuff like "battery empty" should be very similar. If conversion from ADC to voltage is non-trivial, that's a show stopper I guess.
> I still think you've much bigger problems to worry about as this code is > heavily PXA biased and is going to need a lot of changes to work on the > SA1100. Its why I've put it in mach-pxa rather than common and a > separate driver for collie based on this code might be easier.
Actually I think I can refactor in a way that a common core can be share. I'd hate to copy 1000 lines... Pavel
-- Thanks, Sharp! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |