Messages in this thread | | | From | Claudio Scordino <> | Subject | Re: [PATCH] getrusage sucks | Date | Fri, 11 Nov 2005 01:23:28 +0100 |
| |
On Friday 11 November 2005 00:47, Hua Zhong (hzhong) wrote: > The reason is what if tsk is no longer available when you call > getrusage?
Sorry, but honestly I don't see any problem: as you can see from my patch, if tsk is no longer available, getrusage returns -1 and sets errno appropriately (equal to EINVAL, which means that who is invalid).
Claudio
> > > -----Original Message----- > > > > Does exist any _real_ reason why getrusage can't be invoked > > by a task to know > > statistics of another task ? > > > > The changes would be very trivial, as shown by the following patch. > > > > Claudio > > > > > > diff --git a/kernel/sys.c b/kernel/sys.c > > --- a/kernel/sys.c > > +++ b/kernel/sys.c > > @@ -1746,9 +1746,13 @@ int getrusage(struct task_struct *p, int > > > > asmlinkage long sys_getrusage(int who, struct rusage __user *ru) > > { > > - if (who != RUSAGE_SELF && who != RUSAGE_CHILDREN) > > - return -EINVAL; > > - return getrusage(current, who, ru); > > + if (who != RUSAGE_SELF && who != RUSAGE_CHILDREN) { > > + struct task_struct* tsk = find_task_by_pid(who); > > + if (tsk == NULL) > > + return -EINVAL; > > + return getrusage(tsk, RUSAGE_SELF, ru); > > + } else > > + return getrusage(current, who, ru); > > } > > > > asmlinkage long sys_umask(int mask) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |