lkml.org 
[lkml]   [2005]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 9/9] Cleanup a loop in set_slab_attr()
    Last, but not least, fix a loop in set_slab_attr() to match the rest of the
    functionally similar loops in mm/slab.c.

    -Matt
    Change the
    do { ... } while (--i);
    loop in set_slab_attr to a
    while (i--) { ... }
    loop like the rest of the functions that do similar loops in mm/slab.c.

    Signed-off-by: Matthew Dobson <colpatch@us.ibm.com>

    Index: linux-2.6.14+slab_cleanup/mm/slab.c
    ===================================================================
    --- linux-2.6.14+slab_cleanup.orig/mm/slab.c 2005-11-10 11:49:19.028840752 -0800
    +++ linux-2.6.14+slab_cleanup/mm/slab.c 2005-11-10 11:49:21.636444336 -0800
    @@ -2157,11 +2157,11 @@ static void set_slab_attr(kmem_cache_t *

    i = 1 << cachep->gfporder;
    page = virt_to_page(objp);
    - do {
    + while (i--) {
    SET_PAGE_CACHE(page, cachep);
    SET_PAGE_SLAB(page, slabp);
    page++;
    - } while (--i);
    + }
    }

    /*
    \
     
     \ /
      Last update: 2005-11-11 01:09    [W:0.022 / U:63.368 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site