Messages in this thread Patch in this message | | | Subject | Re: fix sparse warning in horizon atm driver. | Date | Thu, 10 Nov 2005 11:00:39 -0500 | From | "chas williams - CONTRACTOR" <> |
| |
In message <20051109055739.GA630@redhat.com>,Dave Jones writes: >these vars get fed u32's, and are OR'd with u32's. >Chances are they were meant to be u32's. > >I don't have hardware to test this, but I can't fathom >why a u16 would be used here.
i guess someone got confused over BUFFER_PTR_MASK. this patch looks fine to me.
[ATM]: [horizon] fix sparse warnings
Signed-off-by: Dave Jones <davej@redhat.com> Signed-off-by: Chas Williams <cmas@cmf.nrl.navy.mil>
--- linus/drivers/atm/horizon.c~ 2005-11-09 00:51:50.000000000 -0500 +++ linus/drivers/atm/horizon.c 2005-11-09 00:55:36.000000000 -0500 @@ -1511,8 +1511,8 @@ static inline short setup_idle_tx_channe // a.k.a. prepare the channel and remember that we have done so. tx_ch_desc * tx_desc = &memmap->tx_descs[tx_channel]; - u16 rd_ptr; - u16 wr_ptr; + u32 rd_ptr; + u32 wr_ptr; u16 channel = vcc->channel; unsigned long flags; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |