lkml.org 
[lkml]   [2005]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] Keys: Remove incorrect and obsolete '!' operators
    Date

    The attached patch removes a couple of incorrect and obsolete '!' operators
    left over from the conversion of the key permission functions from true/false
    returns to zero/error returns.

    Signed-Off-By: David Howells <dhowells@redhat.com>
    ---
    warthog>diffstat -p1 keys-debang-2614rc5mm1.diff
    security/keys/keyring.c | 8 ++++----
    1 files changed, 4 insertions(+), 4 deletions(-)

    diff -uNrp linux-2.6.14-rc5-mm1/security/keys/keyring.c linux-2.6.14-rc5-mm1-keys/security/keys/keyring.c
    --- linux-2.6.14-rc5-mm1/security/keys/keyring.c 2005-11-01 13:22:53.000000000 +0000
    +++ linux-2.6.14-rc5-mm1-keys/security/keys/keyring.c 2005-11-01 13:40:52.000000000 +0000
    @@ -434,8 +434,8 @@ ascend:
    if (sp >= KEYRING_SEARCH_MAX_DEPTH)
    continue;

    - if (!key_task_permission(make_key_ref(key, possessed),
    - context, KEY_SEARCH) < 0)
    + if (key_task_permission(make_key_ref(key, possessed),
    + context, KEY_SEARCH) < 0)
    continue;

    /* stack the current position */
    @@ -621,8 +621,8 @@ struct key *find_keyring_by_name(const c
    if (strcmp(keyring->description, name) != 0)
    continue;

    - if (!key_permission(make_key_ref(keyring, 0),
    - KEY_SEARCH) < 0)
    + if (key_permission(make_key_ref(keyring, 0),
    + KEY_SEARCH) < 0)
    continue;

    /* found a potential candidate, but we still need to
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-11-01 15:19    [W:3.209 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site