Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH consolidate sys_ptrace | Date | Tue, 01 Nov 2005 11:37:54 +0000 |
| |
Christoph Hellwig <hch@lst.de> wrote:
> > The sys_ptrace boilerplate code (everything outside the big switch > > statement for the arch-specific requests) is shared by most > > architectures. This patch moves it to kernel/ptrace.c and leaves the > > arch-specific code as arch_ptrace.
Looks okay to me. I do have a concern about all the extra indirections we're acquiring by this mad rush to centralise everything. It's going to slow things down and consume more stack space. Is there any way we can:
(1) Make a sys_ptrace() *jump* to arch_ptrace() instead of calling it, thus obviating the extra return step.
(2) Drop the use of lock_kernel().
Otherwise, the patch looks valid:
Acked-By: David Howells <dhowells@redhat.com>
David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |