Messages in this thread | | | From | Con Kolivas <> | Subject | Re: [PATCH] vm - swap_prefetch-15 | Date | Fri, 7 Oct 2005 22:33:11 +1000 |
| |
On Fri, 7 Oct 2005 22:26, Pekka J Enberg wrote: > On Fri, 7 Oct 2005, Con Kolivas wrote: > > Makes sense but it is only used in the CONFIG_SWAP_PREFETCH case so it > > would end up as a static inline in swap.h to avoid ending being #ifdefed > > in page_alloc.c. Do you think that's preferable to having it in > > swap_prefetch.c ? > > But then you would still have to open up buffered_rmqueue() and > zone_statistics() to everyone, no?
bah of course.. /me slaps forehead
> How about you implement a new gfp flag > __GFP_NEVER_RECLAIM similar to __GFP_NORECLAIM instead so you don't have > to duplicate __page_alloc()?
That will end up being far more intrusive than this version and __alloc_pages would need more tests that affect every call to __alloc_pages which seems much more expensive to me than exporting buffered_rmqueue and zone_statistics, and the modified __alloc_pages will still be a much more complicated function than prefetch_get_page.
Thanks, Con - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |