lkml.org 
[lkml]   [2005]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH] don't invalidate non-directory mountpoints
From
Date
d_invalidate allowed a non-directory mountpoint to be invalidated,
which is bad, since the mountpoint becomes unreachable.

I know it's racy wrt attaching/detaching mount, but AFAICS so is
everything else that unhashes the dentry. This seems to be an
oversight when splitting out vfsmount_lock from dcache_lock. To be
fixed.

Signed-off-by: Miklos Szeredi <miklos@szeredi.hu>
---
Index: linux/fs/dcache.c
===================================================================
--- linux.orig/fs/dcache.c 2005-10-04 13:59:57.000000000 +0200
+++ linux/fs/dcache.c 2005-10-07 12:59:11.000000000 +0200
@@ -350,7 +350,8 @@ int d_invalidate(struct dentry * dentry)
*/
spin_lock(&dentry->d_lock);
if (atomic_read(&dentry->d_count) > 1) {
- if (dentry->d_inode && S_ISDIR(dentry->d_inode->i_mode)) {
+ if (dentry->d_inode && (S_ISDIR(dentry->d_inode->i_mode) ||
+ d_mountpoint(dentry))) {
spin_unlock(&dentry->d_lock);
spin_unlock(&dcache_lock);
return -EBUSY;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-10-07 13:18    [from the cache]
©2003-2011 Jasper Spaans