Messages in this thread Patch in this message | | | Date | Tue, 04 Oct 2005 14:41:32 +0200 (MEST) | From | Clemens Ladisch <> | Subject | [PATCH 1/7] HPET: Fix mmap() of /dev/hpet |
| |
From: Keir Fraser <keir@xensource.com>
The address passed to io_remap_pfn_range() in hpet_mmap() does not need to be converted using __pa(): it is already a physical address. This bug was found and the patch suggested by Clay Harris.
I introduced this particular bug when making io_remap_pfn_range changes a few months ago. In fact mmap()ing /dev/hpet has *never* previously worked: before my changes __pa() was being executed on an ioremap()ed virtual address, which is also invalid.
Signed-off-by: Keir Fraser <keir@xensource.com>
Index: linux-2.6.13/drivers/char/hpet.c =================================================================== --- linux-2.6.13.orig/drivers/char/hpet.c 2005-10-03 22:52:30.000000000 +0200 +++ linux-2.6.13/drivers/char/hpet.c 2005-10-03 22:53:09.000000000 +0200 @@ -279,7 +279,6 @@ static int hpet_mmap(struct file *file, vma->vm_flags |= VM_IO; vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); - addr = __pa(addr); if (io_remap_pfn_range(vma, vma->vm_start, addr >> PAGE_SHIFT, PAGE_SIZE, vma->vm_page_prot)) { - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |