Messages in this thread | | | Date | Tue, 1 Nov 2005 08:11:43 +1100 | Subject | Re: [PATCH] kill 8139too kernel thread (sorta) | From | Herbert Xu <> |
| |
On Tue, Nov 01, 2005 at 07:50:52AM +1100, Herbert Xu wrote: > > However, in this case it's much easier than that. Simply change > rtl8139_thread to do > > rtnl_lock(); > if (tp->time_to_die == 0) { > rtl8139_thread_iter(dev, tp, tp->mmio_addr); > schedule_delayed_work(&tp->thread, next_tick); > } > rtnl_unlock();
Actually this is no good either. The reason is that rtl8139_stop_thread never relinquinshes the RTNL so it has no way of waiting for this to complete.
So I suppose we will have to use cancel_rearming_delayed_workqueue or create an rtl-specific semaphore for this.
Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |