Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH] x86_64: Work around Re: 2.6.14-git1 (and -git2) build failure on AMD64 | Date | Sun, 30 Oct 2005 17:23:31 +0100 |
| |
On Sunday 30 October 2005 17:17, Roland Dreier wrote: > Andi> Linus, can you please apply it? > > No, please don't apply this. The correct fix is to mark > toshiba_ohci1394_dmi_table[] as __devinitdata in that file, as in the > patch I posted here: > > http://lkml.org/lkml/2005/10/29/12
While not correct I don't see how it should guarantee it will work around that gcc bug on all possible gcc versions (which show different behaviour) My patch is more conservative and safer.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |