lkml.org 
[lkml]   [2005]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [FIXME] Comments on serial and MMC changes in MIPS merge
Russell King wrote:
> Some comments on the recent MIPS merge:
>
> 1. au1xxx mmc driver
>
> mmc_remove_host() does a safe shutdown of the MMC host, removing
> cards and then powering down. This must be called prior to the
> driver thinking of tearing anything down.
>
> As for those disable_irq()...enable_irq(), are you aware that MMC
> can start talking to the host as soon as you've called mmc_add_host() ?
>

I'm also concerned about the ammount of protocol awareness in this
driver. Is there a spec available for this hardware? Perhaps the MMC
layer can export more information so that we can avoid switches on
specific MMC commands?

Rgds
Pierre
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-10-30 12:03    [W:0.044 / U:4.268 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site