lkml.org 
[lkml]   [2005]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ppc64: add MODALIAS= for vio bus
Hi Olaf,

This patch breaks lagacy iSeries i.e. it won't link (iSeries has no get_property()).
It may be easier to redo this patch against Paulus' merge tree.

A couple of trivial comments:

On Sun, 30 Oct 2005 22:39:00 +0100 Olaf Hering <olh@suse.de> wrote:
>
> +static int pseries_vio_hotplug (struct device *dev, char **envp, int num_envp,
^
No space here, please.

> + length = scnprintf (buffer, buffer_size, "MODALIAS=vio:T%sS%s",
^
No space here either, please.

--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2005-10-31 03:50    [W:0.576 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site