Messages in this thread | | | From | Ingo Oeser <> | Subject | Re: [PATCH 1/3] swsusp: rework swsusp_suspend | Date | Sun, 30 Oct 2005 19:54:00 +0200 |
| |
Hi Rafael,
On Sunday 30 October 2005 16:40, Rafael J. Wysocki wrote: > This patch makes only the functions in swsusp.c call functions in snapshot.c > and not both ways. Basically, it moves the code without changing its > functionality.
This is not quite true.
> #else > -static int save_highmem(void) { return 0; } > +int save_highmem(void) { return 0; } > int restore_highmem(void) { return 0; } > #endif /* CONFIG_HIGHMEM */
Here you change code, which will be optimized completely away to an empty function, which bloats the kernel.
Please put these two functions into a local header like this:
#ifdef CONFIG_HIGHMEM int save_highmem(void); int restore_highmem(void); #else static inline int save_highmem(void) { return 0; } static inline int restore_highmem(void) { return 0; } #endif
That way no having no highmem means, this code is not used at all and everything using the return code and expecting != 0 is going to be optimized away.
I think everyone CCed will agree here :-)
Many thanks & Regards
Ingo Oeser
[unhandled content-type:application/pgp-signature] | |