Messages in this thread | | | Date | Sun, 30 Oct 2005 14:53:04 +1100 | From | Nick Piggin <> | Subject | Re: [PATCH]: Clean up of __alloc_pages |
| |
Paul Jackson wrote: > Nick, replying to pj: >
>>Hmm, where is the other callsite? > > > The other callsite is mm/swap_prefetch.c:prefetch_get_page(), from Con > Kolivas's mm-implement-swap-prefetching.patch patch in *-mm, dated > about six days ago. >
OK, I haven't looked at those patches really. I think some of that stuff should go into page_alloc.c and I'd prefer to keep buffered_rmqueue static.
But no matter for the cleanup patch at hand: let's leave the inline off, and the compiler will do the right thing if it is static and there is just a single call site (and I think newer gccs will do function versioning if there are constant arguments).
-- SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |