Messages in this thread | | | Date | Sun, 30 Oct 2005 13:01:18 +1100 | From | Nick Piggin <> | Subject | Re: [PATCH]: Clean up of __alloc_pages |
| |
Paul Jackson wrote: > A couple more items: > 1) Lets try for a consistent use of type "gfp_t" for gfp_mask. > 2) The can_try_harder flag values were driving me nuts.
Please instead use a second argument 'gfp_high', which will nicely match zone_watermark_ok, and use that consistently when converting __alloc_pages code to use get_page_from_freelist. Ie. keep current behaviour.
That would solve my issues with the patch.
> 3) The "inline" you added to buffered_rmqueue() blew up my compile.
How? Why? This should be solved because a future possible feature (early allocation from pcp lists) will want inlining in order to propogate the constant 'replenish' argument.
> 4) The return from try_to_free_pages() was put in "i" for no evident reason. > 5) I have no clue what the replenish flag you added to buffered_rmqueue does. >
Slight patch mis-split I guess. For the cleanup patch, you're right, this should be removed.
-- SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |