Messages in this thread | | | Date | Sat, 29 Oct 2005 12:57:49 -0700 | From | Greg KH <> | Subject | Re: [PATCH] toshiba_ohci1394_dmi_table should be __devinitdata, not __devinit |
| |
On Sat, Oct 29, 2005 at 07:43:59AM -0700, Jesse Barnes wrote: > On Friday, October 28, 2005 9:50 pm, Roland Dreier wrote: > > I don't really understand why gcc gives the error it does, but > > without this patch, when building with CONFIG_HOTPLUG=n, I get errors > > like: > > > > CC arch/x86_64/pci/../../i386/pci/fixup.o > > arch/x86_64/pci/../../i386/pci/fixup.c: In function > > `pci_fixup_i450nx': arch/x86_64/pci/../../i386/pci/fixup.c:13: error: > > pci_fixup_i450nx causes a section type conflict > > > > The change is obviously correct: an array should be declared > > __devinitdata rather that __devinit. > > Oops, yeah I think this is correct. We should also mark > toshiba_line_size as __devinitdata. Patch relative to yours.
Why? Is it really worth it? 2 bytes? Ick.
It's time to just make CONFIG_HOTPLUG always on to keep messes like this from happening...
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |