lkml.org 
[lkml]   [2005]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] [KDUMP] pending interrupts problem
From
Date
seems to bad patch. you dereference pointer (1) before check to NULL(2).

> ---
>
> arch/i386/kernel/smp.c | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> applies-to: e6a6c8ed12ba1ef7fa376fa3993e3c329e9f294a
> 195ab3620ba410697ad78957226c5493d55dd2ee
> diff --git a/arch/i386/kernel/smp.c b/arch/i386/kernel/smp.c
> index 218d725..3d33125 100644
> --- a/arch/i386/kernel/smp.c
> +++ b/arch/i386/kernel/smp.c
> @@ -560,6 +560,7 @@ int smp_call_function (void (*func) (voi
> if (wait)
> while (atomic_read(&data.finished) != cpus)
> cpu_relax();
> + call_data = NULL;
> spin_unlock(&call_lock);
>
> return 0;
> @@ -609,6 +610,14 @@ fastcall void smp_call_function_interrup
> int wait = call_data->wait;
(1) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> ack_APIC_irq();
> +
> + /* Ignore spurious IPIs */
> + if (!call_data)
> + return;
(2) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-10-27 18:08    [W:1.914 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site