lkml.org 
[lkml]   [2005]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 4 of 6] tpm: move atmel driver off pci_dev
Date
Le Tue, 25 Oct 2005 10:22:02 -0500, Kylene Jo Hall a écrit :


> +static int __init init_atmel(void)
> {
> - u8 version[4];
> int rc = 0;
> int lo, hi;
>
> - if (pci_enable_device(pci_dev))
> - return -EIO;
> + driver_register(&atml_drv);
>
> lo = tpm_read_index(TPM_ADDR, TPM_ATMEL_BASE_ADDR_LO);
> hi = tpm_read_index(TPM_ADDR, TPM_ATMEL_BASE_ADDR_HI);
>
Hum shouldn't you check that this port isn't used with request_region ?

Matthieu

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-10-27 23:57    [W:8.194 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site