Messages in this thread | | | Date | Thu, 27 Oct 2005 11:26:35 -0700 | From | Andrew Morton <> | Subject | Re: [patch 1/1] export cpu_online_map |
| |
Paul Jackson <pj@sgi.com> wrote: > > Andrew wrote: > > Sweet, thanks. Perhaps we can remove cpu_online_map from UP builds soon - > > it's really wrong to have it there. > > Eh ... my gut reaction is different. Even uni-processors have > online cpus - just not very many of them (and hot unplugging one > of them is frowned on).
That's daft. A uniprocessor machine has one and only one CPU and it's always online! An online_map is only needed for MP.
Now conceptually, yes, we should be able to query and perhaps set the onlineness of a CPU. But that doesn't mean that we should have storage which idiotically remembers something which was known at compile time.
> Why make special cases when it serves no purpose?
Ths presence of cpu_online_map in UP builds _is_ a special case. The kernel's overall approach to such things is to optimise them away at compile time for !SMP builds.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |