Messages in this thread | | | Date | Sun, 23 Oct 2005 22:13:20 +0100 | From | Russell King <> | Subject | Re: [patch] drivers/block: updates .owner field of struct pci_driver |
| |
On Sun, Oct 23, 2005 at 10:49:48PM +0200, Laurent Riffard wrote: > This patch updates .owner field of struct pci_driver. > > This allows SYSFS to create the symlink from the driver to the > module which provides it. > > Signed-off-by: Laurent Riffard <laurent.riffard@free.fr>
Wouldn't it be better to eliminate pci_driver's .owner field and set the generic device driver's owner field directly? (and fix the PCI code not to overwrite that if pci_driver's .owner field is NULL for compatibility.)
I ask for the second time recently on linux-kernel. Is there *really* any point in duplicating these fields?
-- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |