Messages in this thread | | | Date | Fri, 21 Oct 2005 15:28:17 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 2/4] swsusp: clean up resume error path |
| |
Hi!
> > I don't like this one. restore_highmem() does freeing of allocated > > pages. If swsusp_arch_suspend() fails in specific way, I suspect it > > could leak highmem. > > The pages to be freed are only allocated in suspend_prepare_image() > (now swsusp_save()), which is on suspend, and this is the resume > error path.
Ok, yes, you seem to be right. I was probably confused by my own code. ACK on the patch (if it helps you).
Pavel
-- Boycott Kodak -- for their patent abuse against Java. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |