lkml.org 
[lkml]   [2005]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] nvidiafb: PPC & mode setting fixes (#2)
    Benjamin Herrenschmidt wrote:
    > (This version removes a useless bit that slipped in the previous one)
    >
    > This patch fixes a couple of things in nvidiafb:
    >
    > - The code for retreiving the mode from Open Firmware was broken. It
    > would crash at boot and was copied from the old rivafb code that didn't
    > work very well (I'll update rivafb too one of these days).

    What do you think of making EDID retrieval from the OF generic? Or is
    it too much hassle?

    >
    > - The mode setting code produced weird results on the 5200 card in the
    > iMac G5 here. X "nv" code works fine though. After comparing them, I
    > found out that we aren't really manipulating some VGA bits the same way
    > and X code seemed better, so I slightly changed the mode setting to do
    > the same and that fixed the problem. (The display was strangely shifted
    > with garbage in the margin but not on all lines, and not in bpp 32)
    >
    > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

    Thanks for the fix :-)

    Acked-by: Antonino Daplas <adaplas@pol.net>
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-10-02 09:11    [W:0.021 / U:65.496 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site