Messages in this thread Patch in this message | | | From | Dmitry Torokhov <> | Subject | Re: [PATCH] uinput crash maybe this is the FIX | Date | Mon, 17 Oct 2005 00:55:47 -0500 |
| |
On Sunday 16 October 2005 17:06, emard@softhome.net wrote: > HI > > THanks for all the hints. > > Here's my fix for the situation in the uinput. > It generally breaks when Force feedback is removed, > sometimes request id slot is not freed correctly and > it can lead to crash and/or running out of slots. > > Without knowing much what I'm doing, I added one > lock and it seems to fix the problem. >
The lock is not really needed, please try the patch below.
-- Dmitry
Input: uniput - fix crash on SMP
Only signal completion after marking request slot as free, otherwise other processor can free request structure before we finish using it.
Signed-off-by: Dmitry Torokhov <dtor@mail.ru> ---
drivers/input/misc/uinput.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
Index: work/drivers/input/misc/uinput.c =================================================================== --- work.orig/drivers/input/misc/uinput.c +++ work/drivers/input/misc/uinput.c @@ -90,11 +90,11 @@ static inline int uinput_request_reserve static void uinput_request_done(struct uinput_device *udev, struct uinput_request *request) { - complete(&request->done); - /* Mark slot as available */ udev->requests[request->id] = NULL; wake_up_interruptible(&udev->requests_waitq); + + complete(&request->done); } static int uinput_request_submit(struct input_dev *dev, struct uinput_request *request) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |