Messages in this thread | | | Date | Mon, 17 Oct 2005 13:28:58 +0200 | From | Andrea Arcangeli <> | Subject | Re: Possible memory ordering bug in page reclaim? |
| |
On Sun, Oct 16, 2005 at 11:36:00PM +0400, Ivan Kokshaysky wrote: > Note that superfluous mb's around atomic stuff still can hurt - > Alpha mb instruction also flushes IO write buffers, so it can ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
That's what needed to implement the wmb on alpha, this is why mb is needed there and we need to add it at the top as well to comply with docs (and especially for atomic_dec_and_test kind of usage like Dave said).
Ivan I assume you'll take care of fixing it, thanks! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |