Messages in this thread | | | Date | Tue, 18 Oct 2005 09:03:20 +0800 | From | Coywolf Qi Hunt <> | Subject | Re: [PATCH] mark __init code noinline to stop erroneous inclusions |
| |
On 10/18/05, Ben Dooks <ben@fluff.org.uk> wrote: > Make __init also have the noinline attribute attached > to it, to stop code marked as __init being included > into non __init code. This not only wastes space, but > also makes it impossible to track down any calls from > non-init code as differing compilers and optimisations > make differing decisions on what to inline.
I think this is overkill. __init code could be inlined into __init code. Instead we should make sure to not to call __init code from non-init code `directly'.
It is a gcc bug. Gcc really should respects __attribute__ ((__section__ (".init.text"))), and not inline the code in that section. -- Coywolf Qi Hunt http://sosdg.org/~coywolf/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |