Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [patch] Re: 2.6.14-rc4-mm1 ntfs/namei.c missing compat.h? | Date | Mon, 17 Oct 2005 20:02:23 +0200 |
| |
On Monday 17 October 2005 20:01, Alan Cox wrote: > On Llu, 2005-10-17 at 18:41 +0200, Andi Kleen wrote: > > IMHO the right fix is to put that atomic scrub thingy into another > > include file. It seems to cause major additional include dependencies and > > is only used in a single file right now. > > Every file I looked at (I've not looked at NTFS) included types.h if it > included atomic.h but sometimes directly or indirectly after atomic.h > rather than before. > > I was thinking of just writing a tool to find the other cases and then > fix those I can.
I think it is far better you do it in a different macro in a different file without any nasty dependencies. What you're trying to do has nothing to do with atomic_t anyways. It is just abuse of atomic.h
-Andi
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |