Messages in this thread | | | Date | Mon, 17 Oct 2005 09:53:31 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH] libata: fix broken Kconfig setup |
| |
On Mon, 17 Oct 2005, Linus Torvalds wrote: > > > And then with the quirk issue out of > > the way, CONFIG_SCSI_SATA becomes purely a boolean enable/disable-this-menu > > switch. > > No it does not. You continue to ignore the fact that it's not an > enable/disable thing. It's a "can we enable SATA drivers" vs "can we > enable SATA drivers as modules" vs "do we do any SATA drivers at all?" > thing. > > A tristate.
Btw, if you want to have the _question_ always be y/n only, that's easy enough to do, just make that one do
config SATA_MENU bool "Want to see SATA drivers" depends on SCSI != n
config SCSI_SATA tristate depends on SCSI && SATA_MENU default y
and now you have a totally sensible setup, where the low-level drivers can depend on something sane.
I don't think it _buys_ you anything, but hey, at least it's logical.
Btw, wouldn't it be much nicer to also have this all in a totally separate Kconfig file? That SCSI Kconfig file is one of the biggest ones (yeah, drivers/net/Kconfig is bigger, but hey, that's not a surprise, is it ;)
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |