lkml.org 
[lkml]   [2005]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: Intel SATA combined mode quirk broken for SCSI_SATA=m
    Date
    On Sunday, October 16, 2005 7:33 pm, Jeff Garzik wrote:
    > Overall the quirk is a hack until ATAPI is supported -- but even after
    > ATAPI is supported, we need to figure out some way to keep IDE driver
    > from stealing the legacy IDE ports before libata can touch them :(
    >
    > However, when ATAPI is supported, that at least means that both PATA and
    > SATA can run at full speed.

    But then can't we remove the quirk and just declare them incompatible (i.e.
    who loads first, wins)?

    > Your patch is correct, and should go into 2.6.14-rc post-haste.

    Well, almost. :) I diffed against a bad version. This one should actually
    apply.

    Jesse

    Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

    --- linux-2.6.14-rc4/drivers/pci/quirks.c.orig 2005-10-16 19:46:43.000000000 -0700
    +++ linux-2.6.14-rc4/drivers/pci/quirks.c 2005-10-16 19:12:33.000000000 -0700
    @@ -1233,7 +1233,7 @@
    DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_EESSC, quirk_alder_ioapic );
    #endif

    -#ifdef CONFIG_SCSI_SATA
    +#if defined(CONFIG_SCSI_SATA) || defined(CONFIG_SCSI_SATA_MODULE)
    static void __devinit quirk_intel_ide_combined(struct pci_dev *pdev)
    {
    u8 prog, comb, tmp;
    \
     
     \ /
      Last update: 2005-10-17 04:51    [W:0.043 / U:56.804 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site