Messages in this thread | | | Date | Wed, 12 Oct 2005 18:04:34 +0900 | From | "Machida, Hiroyuki" <> | Subject | Re: [PATCH 1/2] miss-sync changes on attributes (Re: [PATCH 2/2][FAT] miss-sync issues on sync mount (miss-sync on utime)) |
| |
Andrew Morton wrote: > "Machida, Hiroyuki" <machida@sm.sony.co.jp> wrote: > >> >> >>OGAWA Hirofumi wrote: >> >>>Andrew Morton <akpm@osdl.org> writes: >>> >>> >>> >>>>However there's not much point in writing a brand-new function when >>>>write_inode_now() almost does the right thing. We can share the >>>>implementation within fs-writeback.c. >>> >>> >>>Indeed. We use the generic_osync_inode() for it? >> >>Please let me confirm. >>Using generic_osync_inode(inode, NULL, OSYNC_INODE) instaed of >>sync_inode_wodata(inode) is peferable for changes on fs/open.c, >>even it would write data. Is it correct? >> > > > I don't know. It depends on what you're actually trying to do, and I don't > recall anyone having described that!
I'm just little confused, because I realized generic_osync_inode(,,OSYNC_INODE) calls sync_inode_now(), however Ogawasa-san pointed out sync_inode_now() which my first patch used is writing data page.
-- Hiroyuki Machida machida@sm.sony.co.jp SSW Dept. HENC, Sony Corp.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |