Messages in this thread |  | | Date | Wed, 12 Oct 2005 19:49:52 +1000 | | From | Paul Mackerras <> | | Subject | Re: [PATCH 15/22] ppc64: PCI Error Recovery: PPC64 core recovery routines |
| |
Linas writes:
> + /* We might not have a pci device, if it was a config space read > + * that failed. Find the pci device now. */ > + if (!dev) { > + while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) { > + if (pci_device_to_OF_node(dev) == event->dn) > + break; > + } > + }
Couldn't we just use PCI_DN(event->dn)->pcidev here? Is there some reason why this would not work in some circumstances? It would be nice to avoid this linear search.
Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |