lkml.org 
[lkml]   [2005]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 15/22] ppc64: PCI Error Recovery: PPC64 core recovery routines
Linas writes:

> + /* We might not have a pci device, if it was a config space read
> + * that failed. Find the pci device now. */
> + if (!dev) {
> + while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
> + if (pci_device_to_OF_node(dev) == event->dn)
> + break;
> + }
> + }

Couldn't we just use PCI_DN(event->dn)->pcidev here? Is there some
reason why this would not work in some circumstances? It would be
nice to avoid this linear search.

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-10-12 11:59    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog