Messages in this thread | | | Date | Tue, 11 Oct 2005 20:05:02 +1000 | From | Rudolph Pereira <> | Subject | Re: [PATCH 2.6.14-rc3] sis5513.c: enable ATA133 for the SiS965 southbridge |
| |
On Fri, Oct 07, 2005 at 11:36:46AM -0500, Wes Newell wrote: > It appears to me that this patch will try and apply itself to the real > SIS_180 which has the same true_id of 0x180. Can someone tell me what > will happen then? Indeed, I've tried Aurelien's patch and it works fine for me (on an asus k8s-mx motherboard). Going back over the reasons for the patch that is in -mm that I submitted, which was a rework of a patch that Arnaud Patard/Uwe Koziolek sent to linux-ide, it seems that the thinking was that complex probing and/or configuration was required for this chipset. I don't have any specs to work from, and am not the expert in any case, but it would seem that this is not necessary, and just doing a standard detect of the southbridge id is fine.
Unless anyone has stronger evidence/experience, it would seem that the simplest/cleanest solution is an update to SiSHostChipInfo[], as in Aurelien's patch. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |