lkml.org 
[lkml]   [2005]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH2 4/6] isicom: Pci probing added
On Sun, Oct 09, 2005 at 09:42:22PM +0200, Jiri Slaby wrote:
> @@ -191,6 +198,7 @@ struct isi_board {
> u8 isa;
> spinlock_t card_lock; /* Card wide lock 11/5/00 -sameer */
> unsigned long flags;
> + struct device device;

What is this "struct device" used for? You do not need it.

> + printk(KERN_DEBUG "ISICOM: I/O Region 0x%x-0x%x is busy. "
> + "Card%d will be disabled.\n", board->base,
> + board->base + 15, index + 1);

For all of your printk() calls, please use dev_dbg() or dev_warn() or
the other dev_* calls please.

> +/* isi_card[idx].base = io[idx];
> + isi_card[idx].irq = irq[idx];
> + isi_card[idx].isa = YES;
> + FIXME: which device for request_firmware use? if you know, uncomment this and
> + delete printk and return
> + isi_card[idx].device = ???;

Register the firmware request for when you see the device that needs it,
in your probe function, not in your module init function.

Hope this helps,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-10-10 17:00    [from the cache]
©2003-2011 Jasper Spaans