Messages in this thread | | | Date | Tue, 11 Oct 2005 01:05:03 +0100 | From | Al Viro <> | Subject | Re: [PATCH] Use of getblk differs between locations |
| |
On Mon, Oct 10, 2005 at 09:07:34PM -0300, Glauber de Oliveira Costa wrote: > if (!bh) > return -EIO; > new = sb_getblk(sb, to); > + if (!new) > + return -EIO;
You've just introduced a leak here, obviously.
Please, read the code before "fixing" that stuff; slapping returns at random and hoping that it will help is not a good way to deal with that - the only thing you achieve is hiding the problem.
The same goes for the rest of patch - in each case it's not obvious that your changes are correct. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |